Add aarch64 support #35

meyskens · 2017-07-19T14:23:27Z

This PR adds aarch64/arm64 build files for Debian stretch/jessie and Ubuntu Xenial and newer.
This PR is like #25 (sorry saw it right before sending this in) but uses the golang-backports apt repo till Go builds aarch64 binaries and is not only for Ubuntu Xenial.

I tested running the .deb on Debian Stretch. Any feedback welcome.

douglasmiranda · 2017-07-31T05:46:15Z

So, I'd like to share my experiences with packaging docker aarch on Pine64 running DietPI.

I tried to make deb with the Debian Jessie aarch Dockerfile, but with no success. So I changed the image to arm64v8/debian:jessie-backports. For Debian Jessie there is no aarch64 build on stable channel, only on backports.

As you can see here:

https://packages.debian.org/jessie/libseccomp-dev
https://packages.debian.org/jessie-backports/libseccomp-dev

More info:

Documented the steps here:
https://gist.github.com/douglasmiranda/41c582be2e216f09e1c1081a69e66f87

As you can see on my steps, I've cloned the /docker-ce repo no /docker-ce-packaging.

So my doubt is, the code from here will be merged on /docker-ce?

I hope I could help, please tell if there's a misconception from my part.

douglasmiranda · 2017-08-05T23:15:11Z

There's this too: https://github.com/moby/moby/blob/master/contrib/builder/deb/aarch64/debian-jessie/Dockerfile haven't tried yet.

meyskens · 2017-08-25T12:09:15Z

@douglasmiranda thx (sorry for the delay) will add backports on Jessie

douglasmiranda · 2017-08-25T19:07:16Z

xD Nice!

suihkulokki · 2017-09-04T10:18:47Z

deb/ubuntu-zesty/Dockerfile.aarch64

@@ -0,0 +1,28 @@
+FROM multiarch/ubuntu-core:arm64-yakkety


This for ubuntu zesty, so arm64-yakkety is incorrect image. I think using arm64v8/ubuntu:zesty is would be the best here. arm64v8/ seems to be the closest thing to official debian/ubuntu images and should probably be used elsewhere

suihkulokki · 2017-09-04T10:35:40Z

deb/debian-jessie/Dockerfile.aarch64

+# allow replacing httpredir or deb mirror
+ARG APT_MIRROR=deb.debian.org
+RUN sed -ri "s/(httpredir|deb).debian.org/$APT_MIRROR/g" /etc/apt/sources.list
+RUN echo "deb http://$APT_MIRROR/debian jessie-backports main" >> /etc/apt/sources.list


perhaps use arm64v8/debian:jessie-backports ?

suihkulokki · 2017-09-04T10:40:02Z

Generally looks good to me. I think using the arm64v8 namespace for base images would be an improvement.

meyskens · 2017-09-04T11:21:49Z

@suihkulokki will do!

suihkulokki · 2017-09-05T06:17:12Z

Looks good to me now 👍

DieterReuter · 2017-10-04T12:50:40Z

Any progress here? I'd like to get Debian supported.
@meyskens you should at least resolve the conflict in file "detect_alpine_image".

vielmetti · 2017-10-04T13:02:03Z

I'd like to see this as well, echoing @DieterReuter - one of the desired endpoints for this is an arm64 build for the Raspberry Pi 3.

justincormack · 2017-10-04T13:12:11Z

Needs a rebase

meyskens · 2017-10-04T13:12:47Z

Rebase done

StefanScherer · 2017-10-04T13:24:52Z

detect_alpine_image

@@ -6,7 +6,9 @@ img="unknown"
 if [ "$arch" = "x86_64" ]; then
    img="alpine"
 elif [ "$arch" = "armv7l" ]; then
-    img="arm32v6/alpine"
+    img="armhf/alpine"


I think this PR shouldn't change the behaviour for other platforms. Probably an artifact of other parallel merges. Upstream already contains the changes for armv7l and aarch64.

Indeed, that was the just solved merge conflict

vielmetti · 2017-10-04T13:28:12Z

It's worth noting that there is work in progress to get a multiarch Alpine image, per gliderlabs/docker-alpine#304 . That's not done yet, but when it is done this will simplify the logic.

thaJeztah · 2017-10-04T14:04:50Z

ping @seemethere @andrewhsu @tianon PTAL

tianon · 2017-10-04T14:06:44Z

deb/ubuntu-zesty/Dockerfile.aarch64

@@ -0,0 +1,28 @@
+FROM aarch64/ubuntu:zesty


This one should be arm64v8/ubuntu as well. 👍

tianon · 2017-10-04T14:07:17Z

detect_alpine_image

@@ -7,6 +7,8 @@ if [ "$arch" = "x86_64" ]; then
    img="alpine"
 elif [ "$arch" = "armv7l" ]; then
    img="arm32v6/alpine"
+elif [ "$arch" = "aarch64" ]; then
+    img="arm64v8/alpine"


This block is already down a few lines 😄

tianon · 2017-10-04T14:10:12Z

deb/debian-jessie/Dockerfile.aarch64

+
+RUN apt-get update && apt-get install -y apparmor bash-completion btrfs-tools build-essential cmake curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libltdl-dev libseccomp-dev pkg-config vim-common libsystemd-dev gnupg dirmngr --no-install-recommends && rm -rf /var/lib/apt/lists/*
+
+ENV GO_VERSION 1.9


For consistency across arches, this should still be 1.8.3, shouldn't it? (and they should all be updated together?)

Oh duh, there weren't binary releases of Go for arm64 until 1.9 -- makes more sense. 😇

Oh, that may be an issue still; we were holding off bumping to 1.9 as there were still some issues (possibly not for all architectures though); moby/moby#33892

ericcurtin · 2017-10-25T21:09:44Z

👍 Personally I'd be hoping to add fedora 27 support as it is creating disk images for lots of boards

docker/docker-install#40

Maybe I can take a peek at your work and get it done sometime!

DieterReuter · 2017-10-31T18:59:26Z

Hmm, I'm not quite sure why this PR is still pending. Do we really have any major concerns to merge it? Or what parts should be fixed to finally accept it? I'd really love to get this in!

meyskens · 2017-10-31T19:06:42Z

@DieterReuter from my understanding it is Go 1.9 which is the first with official arm64 support. If wanted I can always build 1.8.x from source if 1.9 support is far away

DieterReuter · 2017-10-31T19:56:08Z

Yes maybe, but there is already a version for Ubuntu Xenial built witn Go 1.8.5, just see here https://github.com/docker/docker-ce-packaging/blob/master/deb/ubuntu-xenial/Dockerfile.aarch64.

DieterReuter · 2017-10-31T20:57:02Z

@meyskens wait, I think there is a new solution now! All the other .deb builds are now based upon Go v1.8.5 and actually there is a new pre-built Go v1.8.5 tarball available for armv8! Here it is https://redirector.gvt1.com/edgedl/go/go1.8.5.linux-arm64.tar.gz. So you could now use Go v1.8.5 directly. WDYT?

So you just have to use

ENV GO_VERSION 1.8.5

and it will work now!

meyskens · 2017-11-01T11:06:38Z

Oh hey that is nice! Changed the versions to 1.8.5

douglasmiranda · 2017-11-24T20:55:21Z

Just a feedback

I'm using Docker aarch64 on Debian Stretch for two weeks, no issues so far.

I've tried the multiarch official images;
and created some of my own;
using docker-compose (in a container);

Running now: samba file server, afp file server (netatalk), boinc.

Details: https://gist.github.com/douglasmiranda/6c78a82b71f626c8deb930bede6d7dfc

No issues, no warnings, only joy xD

DieterReuter · 2017-11-30T14:12:19Z

Ping @thaJeztah. Could you please 🙏 verify internally what we have to do in order to get this PR merged in the near future?
IMO this PR seems to be ready to get merged, it works great for me and @douglasmiranda as well.

vielmetti · 2017-11-30T14:53:11Z

reping @seemethere @andrewhsu @tianon PTAL

thaJeztah · 2017-12-02T04:42:19Z

Checking 🤗

seemethere · 2017-12-04T19:48:33Z

Going to squash and merge this in due to the number of commits.

Signed-off-by: Eli Uriegas <[email protected]>

seemethere

LGTM

seemethere · 2017-12-04T19:53:51Z

Thank you so much @meyskens and everyone else that participated in this PR, sorry for the delay but happy to get more aarch64 support up and running for the upcoming release!

DieterReuter · 2017-12-04T20:24:33Z

🎉woot!

add aarch64 support

38a463d

douglasmiranda mentioned this pull request Aug 5, 2017

Package docker-engine missing in Debian Stretch/Jessie sources aarch64(arm64) moby/moby#33783

Closed

Maartje Eyskens and others added 2 commits August 25, 2017 10:29

use go 1.9 for arm64 support

0a6b108

Merge branch 'master' into master

f1623b7

Maartje Eyskens added 6 commits August 25, 2017 14:10

fixtypo

588f1da

Merge branch 'master' of github.com:meyskens/docker-ce-packaging

1e48ef1

add backports on jessie

bfd8486

fix path

7f516da

delet yakkety

08a7fa3

rm golang-go

4d1a3a3

suihkulokki reviewed Sep 4, 2017

View reviewed changes

use arm64v8/ images

9220fae

StefanScherer mentioned this pull request Oct 4, 2017

Removes yakkety support, removes old raspbian repo docker/docker-install#39

Merged

Merge branch 'master' into master

bbe2624

StefanScherer reviewed Oct 4, 2017

View reviewed changes

fix error made in merge

04e841d

tianon reviewed Oct 4, 2017

View reviewed changes

meyskens added 2 commits October 4, 2017 16:10

remove double architecture

106ee35

use arm64v8/

b3314a3

DieterReuter mentioned this pull request Oct 30, 2017

cannot build on raspberry pi with arm64 DieterReuter/arm64-docker-builder#9

Open

Merge branch 'master' into master

9cb1ffb

Merge branch 'master' into master

03f02ec

use go 1.8.5

c746146

seemethere added 2 commits December 4, 2017 11:46

Merge branch 'master' into master

0a3835b

Merge branch 'master' into master

d76c1d6

Update aarch64 builds to 1.9.2

f007ee9

Signed-off-by: Eli Uriegas <[email protected]>

seemethere approved these changes Dec 4, 2017

View reviewed changes

seemethere merged commit 03eac42 into docker:master Dec 4, 2017

ZeuAlex mentioned this pull request Dec 14, 2017

Aarch64 rpm support #71

Merged

seemethere mentioned this pull request Dec 21, 2017

[17.12] Update changelog docker-archive/docker-ce#369

Merged

thaJeztah mentioned this pull request Jun 8, 2018

arm64 support in the Docker official document moby/moby#37217

Closed


		RUN apt-get update && apt-get install -y apparmor bash-completion btrfs-tools build-essential cmake curl ca-certificates debhelper dh-apparmor dh-systemd git libapparmor-dev libdevmapper-dev libltdl-dev libseccomp-dev pkg-config vim-common libsystemd-dev gnupg dirmngr --no-install-recommends && rm -rf /var/lib/apt/lists/*

		ENV GO_VERSION 1.9

Add aarch64 support #35

Add aarch64 support #35

Conversation

meyskens commented Jul 19, 2017

douglasmiranda commented Jul 31, 2017

douglasmiranda commented Aug 5, 2017

meyskens commented Aug 25, 2017

douglasmiranda commented Aug 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suihkulokki commented Sep 4, 2017

meyskens commented Sep 4, 2017

suihkulokki commented Sep 5, 2017

DieterReuter commented Oct 4, 2017

vielmetti commented Oct 4, 2017

justincormack commented Oct 4, 2017

meyskens commented Oct 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vielmetti commented Oct 4, 2017

thaJeztah commented Oct 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericcurtin commented Oct 25, 2017

DieterReuter commented Oct 31, 2017

meyskens commented Oct 31, 2017

DieterReuter commented Oct 31, 2017

DieterReuter commented Oct 31, 2017 • edited Loading

meyskens commented Nov 1, 2017

douglasmiranda commented Nov 24, 2017

DieterReuter commented Nov 30, 2017

vielmetti commented Nov 30, 2017

thaJeztah commented Dec 2, 2017 • edited Loading

seemethere commented Dec 4, 2017

seemethere left a comment

Choose a reason for hiding this comment

seemethere commented Dec 4, 2017

DieterReuter commented Dec 4, 2017

DieterReuter commented Oct 31, 2017 •

edited

Loading

thaJeztah commented Dec 2, 2017 •

edited

Loading